[PATCH] CTDB NFS Ganesha example call-out improvements

Amitay Isaacs amitay at gmail.com
Fri Feb 24 00:48:29 UTC 2017


On Thu, Feb 23, 2017 at 4:37 PM, Martin Schwenke <martin at meltin.net> wrote:

> I was adding some wiki documentation about how CTDB's NFS call-outs
> work.  I referenced nfs-ganesha-callout, so I decided to fix it up a
> little, even though it is still just an example in the documentation
> directory.
>
> Please review and maybe push...
>
>
In the patch "ctdb-doc: Fix shellcheck warning in example NFS ganesha
call-out"

            [ -d "$_dir" ] || continue # Handle no directories case

Wouldn't the following make it clearer?

            [ ! -d "$_dir" ] && break   # Handle no directories case

Other patches look fine.

Amitay.


More information about the samba-technical mailing list