[PATCH] Remove backlink handling from transaction commit

Andrew Bartlett abartlet at samba.org
Wed Feb 22 22:23:18 UTC 2017

In general, I think we should not do much work in a transaction commit.
 It makes it harder to tell if the operation really succeeded, as the
operation can succeed but the later commit fails without reference to
what caused the issue.

By moving the backlink handling to the operation callback for ADD, any
failure will be reported with the operation.  (The backlink handling is
already during the operation for modify). 

This also makes it easier to profile the handling, as the work is
clearly connected with the original call.

Please review / comment.

Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-repl_meta_data-Remove-handling-of-backlinks-from-rep.patch
Type: text/x-patch
Size: 22460 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170223/59975d34/0001-repl_meta_data-Remove-handling-of-backlinks-from-rep.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-repl_meta_data-Clarify-that-replmd_private-la_list-i.patch
Type: text/x-patch
Size: 1274 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170223/59975d34/0002-repl_meta_data-Clarify-that-replmd_private-la_list-i.bin>

More information about the samba-technical mailing list