[PATCH] Check if the idmap_hash range is big enough

Rowland Penny repenny241155 at gmail.com
Fri Feb 17 11:36:19 UTC 2017


On Fri, 17 Feb 2017 12:24:05 +0100
Andreas Schneider <asn at samba.org> wrote:

> On Wednesday, 15 February 2017 23:08:19 CET Michael Adam wrote:
> > Regarding your patch:
> > 
> > - The check for 500000 seems a bit heuristic to me.
> > - I (still) don't like the fact that the testparm binary
> >   tests stuff for the modules which are kind of
> >   separate.
> 
> We need to tell the user somehow what he does wrong. Why ist testparm
> not the tool to do that?
> 
> 
> New improved patchset attached.
> 
> 
> Andreas
> 
> 

You appear to have a stutter:

+	  The module divides the the range into subranges for each
                                 ^^^

There is also a typo:

+					"configrued for the the domain
                                         ^^^^^^^^^^

Rowland



More information about the samba-technical mailing list