[PATCH] Modify smbspool_krb5_wrapper to just fall through to smbspool if AUTH_INFO_REQUIRED is not set or is not "negotiate".

Andreas Schneider asn at samba.org
Thu Feb 16 09:02:33 UTC 2017

On Thursday, 16 February 2017 08:23:19 CET Bryan Mason wrote:
> Hello,
> Please review and push this patch for Bug 12575.
> This patch falls back to the smbspool command if AUTH_INFO_REQUIRED is
> not set or is not set to "negotiate".  Because cups-deviced doesn't set
> AUTH_INFO_REQUIRED when searching for devices, this allows the wrapper
> to call smbspool to send the line
>   network smb "Unknown" "Windows Printer via SAMBA"
> back to cups-deviced/cupsd when enumerating devices.
> I believe this patch will also allow the backend to be used both with
> SMB printers that use Kerberos as well as SMB printers that use other
> authentication methods (username,password for example).  This could
> simply configuration for users who don't know the difference.

Thank you very much for your patch Bryan!

Reviewed-By: Andreas Schneider <asn at samba.org>

Can I please get review from a second team member?



Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list