ctdb tests

[Amitay Isaacs]

On Wed, Feb 15, 2017 at 8:41 AM, Martin Schwenke <martin at meltin.net> wrote:

> Hi Andreas,
>
> On Tue, 14 Feb 2017 18:31:10 +0100, Andreas Schneider <asn at samba.org>
> wrote:
>
> > I've just packaged Samba 4.6rc3 and the list of added ctdb tests is huge.
> > Attached is the diff of the spec file. I just want to make sure.
> >
> > You want all these tests installed in the system, and you can run them
> > installed there?
>
> The CTDB tests were not being installed by a top level Samba install:
>
>   https://bugzilla.samba.org/show_bug.cgi?id=12547
>
> They were being installed as part of a standalone CTDB install, which
> is why we didn't notice.
>
> Yes, being able to install all of this is very useful.
>
> Each night we build RPMs for a list of branches.  Then we use
> autocluster to create a cluster.  We install ctdb on the cluster nodes
> and ctdb-tests on a test node.  Then we are able to run ctdb_run_tests
> to run most of the tests on the test node and ctdb_run_cluster_tests to
> run some of the tests against the real cluster.
>
> Having the tests installed matters most for the cluster tests.  There's
> some directory name consistency mangling needed to ensure that the test
> code can find things on the cluster nodes.  The cluster tests aren't
> currently run as part of autobuild... because they need a cluster and
> we've never quite got there...  :-)
>
> peace & happiness,
> martin
>
>
As Martin mentioned, we have a need to be able to package ctdb tests for
daily tests.  For that we rely on building ctdb packages using
ctdb/packaging/RPM/ctdb.spec.in.

We have been adding quite a lot of tests in recent years since there have
been significant changes to the core infrastructure of CTDB.  And the tests
will continue to grow in numbers as long as we are doing new development.
I am not sure if it makes sense for distributions to package ctdb-tests (or
for that matter samba-tests), unless it's a policy to package everything
that gets installed.

We do not rely on distributions packaging ctdb-tests for any sort of
testing.  I would be fine even if distributions decide to drop ctdb-tests
package altogether.

Amitay.