[RFC] vfs_fruit uses wrong xattr name for Mac metadata on FreeBSD
Jeremy Allison
jra at samba.org
Mon Feb 13 19:26:04 UTC 2017
On Sun, Feb 12, 2017 at 09:12:25AM +0100, Ralph Böhme wrote:
>
> thanks Jeremy! Unfortunately the cleanup path 2/4 was broken as it changes the
> define for the rsrc xattr to use the metadata string. Sorry!
>
> Attached patch would fix that, can we just push it on top with the same
> bugnumber or shall I create a new one?
Arggh. Sorry :-(. These nasty little details are just toxic :-).
Push on top with the same bugnumber IMHO.
> From 9ccee25a6ae3f16e44a1b258ed07e2d6b0ddd5fe Mon Sep 17 00:00:00 2001
> From: Ralph Boehme <slow at samba.org>
> Date: Sun, 12 Feb 2017 09:05:50 +0100
> Subject: [PATCH] vfs_fruit: fix resource fork xattr name
>
> Fix resource fork xattr name broken in
> e4d1f8354f97ab9007e4c5f7d164937bdc5cd6f1.
>
> Bug: https://bugzilla.samba.org/show_bug.cgi?id=12490
>
> Signed-off-by: Ralph Boehme <slow at samba.org>
> ---
> source3/modules/vfs_fruit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c
> index 8cd1559..db30359 100644
> --- a/source3/modules/vfs_fruit.c
> +++ b/source3/modules/vfs_fruit.c
> @@ -101,7 +101,7 @@ static int vfs_fruit_debug_level = DBGC_VFS;
> #define ADOUBLE_NAME_PREFIX "._"
>
> #define NETATALK_META_XATTR "org.netatalk.Metadata"
> -#define NETATALK_RSRC_XATTR "org.netatalk.Metadata"
> +#define NETATALK_RSRC_XATTR "org.netatalk.ResourceFork"
>
> #if defined(HAVE_ATTROPEN)
> #define AFPINFO_EA_NETATALK NETATALK_META_XATTR
> --
> 2.9.3
>
More information about the samba-technical
mailing list