[PATCH] Do not regard old one-way links as errors (flapping test)

Andrew Bartlett abartlet at samba.org
Sun Feb 12 07:56:11 UTC 2017

The dbcheck flapping test came up for me recently, and I figured out
what was going on and how to fix it.

Attached is a patch that passes 5 autobuilds on the Catalyst Cloud, and
should make dbcheck no longer flap.

Since we didn't choose to implement psudo-backlinks, we do not know
about one-way links when their target is renamed.  Instead we correct
them at runtime.  dbcheck now noticed the old names, and this caused a
flapping test.  We now change the code to still fix it, but not as an

I already has this reviewed by Garming, but I had to change the
renamedc test to account for this no longer being an error. 

Please review/push!


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dbcheck-Do-not-regard-old-one-way-links-as-errors.patch
Type: text/x-patch
Size: 6735 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170212/1c6a2a28/0001-dbcheck-Do-not-regard-old-one-way-links-as-errors.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dbcheck-links-Test-that-dbcheck-against-one-way-link.patch
Type: text/x-patch
Size: 2538 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170212/1c6a2a28/0002-dbcheck-links-Test-that-dbcheck-against-one-way-link.bin>

More information about the samba-technical mailing list