[PATCH] add generated NTSTATUS error module for python

Andrew Bartlett abartlet at samba.org
Sat Feb 11 20:13:34 UTC 2017

On Wed, 2017-02-01 at 15:15 +1300, Bob Campbell wrote:
> Hi again,
> Attached are some patches that build on top of the NTSTATUS patches
> to
> also generate WERROR codes and descriptions, as well as a similar
> script
> to the one attached with the NTSTATUS patches to make sure that we
> aren't missing any.
> Please review and push if appropriate, once the NTSTATUS patches
> (currently in autobuild) have landed.

Sadly this fails autobuild, so I did a bisect with:

./script/bisect-test.py --good=origin/master --bad=gen-error --test-
command='make test FAIL_IMMEDIATELY=1 TESTS=acl.py'

I've pushed the gen-error branch I've used to my repo.

3c24ff1d189b7eade045591975d361d13e59b6c6 is the first bad commit
commit 3c24ff1d189b7eade045591975d361d13e59b6c6
Author: Bob Campbell <bobcampbell at catalyst.net.nz>
Date:   Fri Jan 20 12:24:53 2017 +1300

    errors: add WERROR generation to build system
    Parts of doserr.c and werror.h are now generated into werror_gen.c
    werror_gen.h, respectively. Also, py_werror.c is now generated.
    Some errors were not included in the list which we now generate
    from. These errors have been manually included.
    Signed-off-by: Bob Campbell <bobcampbell at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

Fails with:

REASON: Exception: Exception: Traceback (most recent call last):
  File "/data/samba/git/samba/source4/dsdb/tests/python/acl.py", line
1792, in setUp
  File "/data/samba/git/samba/source4/dsdb/tests/python/acl.py", line
1870, in create_dc
  File "bin/python/samba/join.py", line 614, in join_add_objects
  File "bin/python/samba/join.py", line 545, in join_add_ntdsdsa
  File "bin/python/samba/join.py", line 495, in DsAddEntry
AttributeError: 'NoneType' object has no attribute 'extended_err'

Can you please look at this?


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list