[PATCH] vfs_acl_xattr|tdb: set create mask to 0777 if ignore_system_acls is set

[Ralph Böhme]

On Fri, Feb 10, 2017 at 11:31:38AM -0800, Jeremy Allison wrote:
> On Thu, Feb 09, 2017 at 11:03:21AM -0800, Jeremy Allison wrote:
> > On Mon, Feb 06, 2017 at 01:19:48PM +0100, Ralph Böhme wrote:
> > > Hi!
> > > 
> > > Attached is a patch for bug
> > > https://bugzilla.samba.org/show_bug.cgi?id=12562
> > > 
> > > The fix for bug #12181 included a change that should ensure filesystem
> > > permissions are out of the way when using VFS modules acl_xattr or acl_tdb with
> > > "acl_xattr:ignore system acls = yes".
> > > 
> > > At runtime, when the module is loaded, we set "create mask = 0666" which doesn't
> > > contain executable rights files. This should really by "create mask = 0777"
> > > instead.
> > > 
> > > Please review & push if happy. Thanks!
> > 
> > Hi Ralph,
> > 
> > Can you explain the customer scenario that instigated
> > this fix ?
> > 
> > It's *probably* right, but I think Uri is asking the
> > right questions about defauling files to 'x' access
> > and I want to understand the exact failure case before
> > I OK this :-).
> 
> Ping Ralph, I'd love to get this sorted asap.

sorry for keeping you waiting, but I am strill struggling with struggling with
adding name translation caching to catia for handle based VFS ops as requested
by Uri. Part of the large fruit patchset review... I believe I finally have a
version that is works and is safe. More on that later.

Cheerio!
-slow