[PATCH] vfs_acl_xattr|tdb: set create mask to 0777 if ignore_system_acls is set

Uri Simchoni uri at samba.org
Mon Feb 6 12:47:08 UTC 2017


On 02/06/2017 02:19 PM, Ralph Böhme wrote:
> Hi!
> 
> Attached is a patch for bug
> https://bugzilla.samba.org/show_bug.cgi?id=12562
> 
> The fix for bug #12181 included a change that should ensure filesystem
> permissions are out of the way when using VFS modules acl_xattr or acl_tdb with
> "acl_xattr:ignore system acls = yes".
> 
> At runtime, when the module is loaded, we set "create mask = 0666" which doesn't
> contain executable rights files. This should really by "create mask = 0777"
> instead.
> 
> Please review & push if happy. Thanks!
> 
> Cheerio!
> -slow
> 
Well, what if I want files created to be 0666? Is there a way to make
the create mask 0777 only if the current create mask is not
world-writable (i.e. only as a fix for an incompatible conf)?



More information about the samba-technical mailing list