[PATCH] Fix dn+binary linked attribute behavior (bug 11139)

Stefan Metzmacher metze at samba.org
Thu Feb 2 07:39:31 UTC 2017

Hi Bob,

> +	ret = samldb_unique_attr_check(ac, "linkID", NULL,
> +				       ldb_get_schema_basedn(
> +					     ldb_module_get_ctx(ac->module)));

Can you please use helper variables instead of passing
function calls as arguments?

The commit [PATCH 3/4] torture/drs: Add a test for dn+binary linked
seems to have unrelated changes, can you split the domainFunctionality
change to a separate commit? I guess the source4/selftest/tests.py
change can also move to that commit.

The test seems to be written before commit
I guess you need to apply the same logic in order to avoid oid conflicts.

Otherwise it looks good.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170202/89da80ef/signature.sig>

More information about the samba-technical mailing list