[PATCH] s3/script/findsmb.in: rewrite in modern perl

Andreas Schneider asn at samba.org
Wed Feb 1 15:05:12 UTC 2017


On Wednesday, 1 February 2017 14:18:44 CET Aurélien Aptel wrote:
> Hi,
> 
> This is a pretty old script: I'm not even sure if anyone still uses
> it...
> 
> But since the code was old and small yet hard to follow I've
> taken the liberty to rewrite it.
> 
> I've pretty much kept the CLI arguments and output the same. Code is
> more readable and shorter. I have also added a -h option for help.

That's great,

you probably want to add the following patch:

https://git.samba.org/?p=asn/
samba.git;a=commitdiff;h=a9c831cd2ad47c77484c072538a0267afbeef130



Someone also sent a patch some time ago:

https://git.samba.org/?p=asn/
samba.git;a=commitdiff;h=fed597191fd2ca6263d4124410bee0e66ffb6603

I've never looked into the details, perl is horror to me ;-)


Did you check if the options (-d, -r) are working?



	Andreas



-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list