Latest AV code

[Trever L. Adams]

On 12/27/2017 05:31 PM, jim wrote:
> Trever,
> You missed one change to 'if (!ok)' and one change to 'if (ok)'.
> Jim
>
> On 12/27/2017 7:03 PM, Trever L. Adams wrote:
>> @@ -635,8 +647,8 @@ static virusfilter_action
>> virusfilter_do_infected_file_action(
>>           } else {
>>               DBG_DEBUG("quarantine: Creating "
>>                     "directory %s\n", temp_path);
>> -            if (quarantine_create_dir(handle,
>> -                config, temp_path) == false)
>> +            ok = quarantine_create_dir(handle, config, temp_path);
>> +            if (ok == false)
>
> On 12/27/2017 7:03 PM, Trever L. Adams wrote:
>> @@ -112,10 +113,11 @@ static virusfilter_result
>> virusfilter_fsav_scan_init(
>>           DBG_DEBUG("fsavd: Checking if connection is alive\n");
>>             /* FIXME: I don't know the correct PING command format... */
>> -        if (virusfilter_io_writefl_readl(io_h, &reply, "PING") ==
>> -            true)
>> +        ok = virusfilter_io_writefl_readl(io_h, &reply, "PING");
>> +        if (ok == true)
>
Thank you for catching the second. The first, I think something is
wrong. I have a place in the patch where that line is removed, not added
and in the actual files it is the same. Are you sure it exists as you
are seeing it. I cannot find that line in the patch where it is added.
(It might be in the original rework Ralph did, because it was there
before, but...)

I also have realized I have a small/temporary memory leak in the init
function.

Thank you.

Trever

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 886 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171227/6535464c/signature.sig>