Latest AV code

[Ralph Böhme]

On Tue, Dec 26, 2017 at 11:01:59PM -0700, Trever L. Adams via samba-technical wrote:
> On 12/26/2017 01:41 PM, Jim Brown via samba-technical wrote:
> > Trever
> >
> > ret variable is not a boolean.
> > The check 'if (ret)' should be 'if (ret != 0)'.
> > The check 'if (!ret)' should be 'if (ret == 0)'.
> >
> > ok variable is a boolean.
> > You should use 'if (!ok)' for a false test - and not either (ok ==
> > false) or (ok != true).
> >
> > Jim
> Jim, thank you. I have taken care of these.

Great, thanks! And thanks Jim for pointing those out. Guess I should have given
you a more explicit hint towards "Please read README.Coding", sorry.

> However, in testing, I am
> finding that the streams scanning code no longer works as expected.
> 
>   virusfilter_vfs_close: Not scanned: only file backed streams can be
> scanned: /home/DATA/trever/eicartestingstream.txt(1/0)
> 
> In the past, the file name showed what vfs_streams_depot was doing:
> /home/DATA/.streams/0F/17/02FD000000000000EF005C0400000000:attached.txt:$DATA

Well, vfs_streams_depot doesn't implement the close VFS operation. Not in master
nor in older vesions, so this can't ever have worked.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/