Latest AV code

[Jim Brown]

Trever

ret variable is not a boolean.
The check 'if (ret)' should be 'if (ret != 0)'.
The check 'if (!ret)' should be 'if (ret == 0)'.

ok variable is a boolean.
You should use 'if (!ok)' for a false test - and not either (ok == 
false) or (ok != true).

Jim

On 12/26/17 14:35, Trever L. Adams via samba-technical wrote:
> +		ret = quarantine_directory_exist(handle, new_dir);
> +		if (ret)

On 12/26/17 14:35, Trever L. Adams via samba-technical wrote:
> +	ret = tevent_req_set_endtime(req, ev, timeval_current_ofs_msec(
> +				    io_h->connect_timeout));
> +	if (!ret)
(multiple places)

On 12/26/17 14:35, Trever L. Adams via samba-technical wrote:
> +			ok = quarantine_create_dir(handle, config, temp_path);
> +			if (ok == false)

On 12/26/17 14:35, Trever L. Adams via samba-technical wrote:
> +	ok = virusfilter_io_writefl_readl(io_h, &reply, "zSCAN %s/%s",
> +					  cwd_fname, fname);
> +	if (ok != true)
(multiple places)