[PATCHSET] Add support for fall through attribute

Andreas Schneider asn at samba.org
Thu Dec 21 19:00:41 UTC 2017


On Monday, 18 December 2017 09:47:03 CET Andrew Bartlett wrote:
> On Wed, 2017-12-13 at 10:47 +0100, Andreas Schneider wrote:
> > On Wednesday, 13 December 2017 10:24:13 CET Andrew Bartlett wrote:
> > > I'll have another go at it this week.
> > 
> > Thank you very much!
> > 
> > > I'm particularly concerned about the tldap change because it implies
> > > there isn't a testsuite for it.
> > 
> > source3/torture/torture.c see run_tldap()
> > 
> > /* test search filters against rootDSE */
> > 
> > 
> > There is a test but I don't see that this test is planned in selftest.
> 
> Can you fix that up, show that the change fixes a bug and re-submit?

I'm not sure. Either you need to remove the p++ and FALL_THROUGH or we have to 
add a break.

However I think we should make the TLDAP test work which currently fails.



	Andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org





More information about the samba-technical mailing list