[PATCH] Fix two coverity findings

[Volker Lendecke]

Hi!

Review appreciated!

Thanks, Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 66c1c091a3aa9c609a06781d55ec2c1999a3939e Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Tue, 19 Dec 2017 14:11:24 +0100
Subject: [PATCH 1/2] dsdb: Fix CID 1426727 Resource leak

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source4/dsdb/samdb/ldb_modules/encrypted_secrets.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c b/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c
index bc03fee3e21..41caba1c93f 100644
--- a/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c
+++ b/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c
@@ -313,6 +313,8 @@ static int load_keys(struct ldb_module *module, struct es_data *data)
 
 	read = fread(key.data, 1, key.length, fp);
 	if (read == 0) {
+		TALLOC_FREE(frame);
+		fclose(fp);
 		ldb_debug(ldb,
 			  LDB_DEBUG_WARNING,
 			  "Zero length encrypted secrets key file. "
-- 
2.11.0


From 90fc19c036591bee9c76f60ee5514febd35e4e3d Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Tue, 19 Dec 2017 14:13:37 +0100
Subject: [PATCH 2/2] dsdb: Fix CID 1426728 Structurally dead code

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source4/dsdb/samdb/ldb_modules/encrypted_secrets.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c b/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c
index 41caba1c93f..bd335f5a60c 100644
--- a/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c
+++ b/source4/dsdb/samdb/ldb_modules/encrypted_secrets.c
@@ -1668,8 +1668,6 @@ static int es_modify(struct ldb_module *module, struct ldb_request *req)
 		}
 		return ldb_next_request(module, new_req);
 	}
-	req->op.add.message = encrypted_msg;
-	return ldb_next_request(module, req);
 }
 
 static int es_delete(struct ldb_module *module, struct ldb_request *req)
-- 
2.11.0