[PATCH] selftest: fix ordering dependencies caused by NSS_WRAPPER_ (and potentially RESOLV_WRAPPER_) variables

Andreas Schneider asn at samba.org
Tue Dec 19 08:03:21 UTC 2017


On Tuesday, 19 December 2017 04:27:49 CET Jamie McClymont via samba-technical 
wrote:
> Sorry, forgot to commit an indentation fix (to at least make it
> consistent with the surrounding code, by having mixed tabs and spaces...
> - perhaps I should clean up the perl indentation in a future patch: is
> there an agreed indentation style for samba's perl? README.coding talks
> about C and Python only).
> 
> "Fixed" in the attached :)

Hi Jamie,

the description of the first commit message confuses me. What do you mean with 
'running after an nt4_member'? Is the word 'test' missing?

Do you mean that a test against a nt4_member is running and thus setting 
NSS_WRAPPER_HOSTNAME to a value which shouldn't be used when running the 
samba3.rpc.samba3.netlogon test?

In the last hunk, could you use a cmd helper variable like we do in other 
places?


Thanks,


	Andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list