[PATCH] autobuild: fix quoting of --restrict-tests
Douglas Bagnall
douglas.bagnall at catalyst.net.nz
Tue Dec 19 07:54:40 UTC 2017
hi Jamie,
Thanks, that is obviously right.
>> Currently, one must use autobuild.py --restrict-tests="'test1 test2'".
>> Patch removes the need for the nested quoting. Review appreciated.
>>
> --- a/script/autobuild.py
> +++ b/script/autobuild.py
> @@ -83,7 +83,7 @@ tasks = {
>
> "samba-test-only" : [ ("configure", "./configure.developer --with-selftest-prefix=./bin/ab --abi-check-disable" + samba_configure_params, "text/plain"),
> ("make", "make -j", "text/plain"),
> - ("test", "make test FAIL_IMMEDIATELY=1 TESTS=${TESTS}", "text/plain") ],
> + ("test", "make test FAIL_IMMEDIATELY=1 TESTS=\"${TESTS}\"", "text/plain") ],
>
though I would slightly prefer:
+ ("test", 'make test FAIL_IMMEDIATELY=1 TESTS="${TESTS}"', "text/plain") ],
using single quotes for the python string to avoid backslashes inside.
Either way, RB+ me.
Douglas
More information about the samba-technical
mailing list