[PATCH] Final Fix for DNS wildcard performance regression

Garming Sam garming at catalyst.net.nz
Tue Dec 19 00:09:18 UTC 2017


I think you need to comment on why using 'name' is important somewhere
in the patches (as opposed to the alternatives), considering it's the
most important part of the fix.

Apart from that, you can mark them as reviewed by me.


Cheers,

Garming


On 19/12/17 12:21, Andrew Bartlett wrote:
> On Mon, 2017-12-18 at 17:32 +1300, Andrew Bartlett wrote:
>> On Mon, 2017-12-18 at 17:19 +1300, Andrew Bartlett via samba-technical
>> wrote:
>>> On Mon, 2017-12-18 at 13:21 +1300, Andrew Bartlett wrote:
>>>> The attached patches for master partially address the DNS performance
>>>> regression found in Samba 4.7.3.
>>> I've looked into this some more, and the attached patches finish the
>>> job and return the performance to the original behaviour. 
>>>
>>> These are for master, a backport to 4.7 I'll try once it lands.  In the
>>> meantime the patch posted earlier will help a lot.
>>>
>>> Please review and push!
>> Now with more BUG tags.
> Attached is the final version.  Once that is in we can backport the
> variant (attached) to 4.7.  
>
> I need this in master first however to get commit hashes. 
>
> Please review and push!
>
> Thanks,
>
> Andrew Bartlett




More information about the samba-technical mailing list