[RFC] [CTDB] Optimized memory handling.

Amitay Isaacs amitay at gmail.com
Fri Dec 15 17:29:56 UTC 2017


On Fri, Dec 15, 2017 at 9:01 PM, Swen Schillig <swen at vnet.ibm.com> wrote:
> On Fri, 2017-12-15 at 19:48 +1100, Amitay Isaacs via samba-technical
> wrote:
>> On Fri, Dec 15, 2017 at 7:14 PM, Swen Schillig <swen at vnet.ibm.com>
>> wrote:
>> > On Fri, 2017-12-15 at 18:57 +1100, Amitay Isaacs via samba-
>> > technical
>> > wrote:
>> > >
>> > > Please send patches generated with "git format-patch ...".
>> > >
>> > > Amitay.
>> >
>> > The last one was.
>> >
>> > Is it not working for you ?
>> >
>> > Cheers Swen
>> >
>>
>> May be it's not based on the latest master?  Or you have some other
>> patches in your tree.
> Ok, sorry for that.
>
> Let's do this one by one.
> Attached is the first smaller one which is introducing the pools
> to sock_io.

There are multiple changes.  Please split the patch to keep various
fixes separate.

I would prefer to see datapool as part of a context rather than as
static variable. It will be a good idea to add sock_context and an
init function to create the sock_context.  This avoids allocating
datapool off NULL context.

Also, please think of a way to write a small test which can be used to
demonstrate the improvements.

Amitay.



More information about the samba-technical mailing list