[RFC] [CTDB] Optimized memory handling.

Swen Schillig swen at vnet.ibm.com
Fri Dec 15 06:16:47 UTC 2017


On Thu, 2017-12-14 at 14:53 -0500, jim via samba-technical wrote:
> You should not remove the error checks.
> The errors won't happen but that is no reason not to keep the checks.
> The code might change in the future.

I disagree, if a situation cannot happen, then there's no reason to
check for it. If things change in future, then this can too.

Cheers Swen
> 
> On 12/14/2017 2:04 PM, Swen Schillig via samba-technical wrote:
> >   	queue->im = tevent_create_immediate(queue);
> > -	if (queue->im == NULL) {
> > -		talloc_free(queue);
> > -		return NULL;
> > -	}
> > -
> >   	queue->queue = tevent_queue_create(queue, "out-queue");
> > -	if (queue->queue == NULL) {
> > -		talloc_free(queue);
> > -		return NULL;
> > -	}
> 
> 




More information about the samba-technical mailing list