[PR PATCH] Fix crackcheck Makefile to allow building on Ubuntu
github at samba.org
github at samba.org
Thu Dec 14 10:36:38 UTC 2017
There is a new pull request by candlerb against master on the Samba Samba Github repository
https://github.com/candlerb/samba candlerb/crackcheck
https://github.com/samba-team/samba/pull/114
Fix crackcheck Makefile to allow building on Ubuntu
This patch fixes the following failure when attempting to build crackcheck under Ubuntu 16.04:
~~~
# make
gcc -O2 -c -o crackcheck.o crackcheck.c
crackcheck.c: In function âmainâ:
crackcheck.c:91:15: warning: implicit declaration of function âgetoptâ [-Wimplicit-function-declaratio
while ( (c = getopt(argc, argv, "d:cs")) != EOF){
^
gcc -O2 -lcrack -o crackcheck crackcheck.o
crackcheck.o: In function `main':
crackcheck.c:(.text.startup+0xee): undefined reference to `FascistCheck'
collect2: error: ld returned 1 exit status
Makefile:18: recipe for target 'crackcheck' failed
make: *** [crackcheck] Error 1
~~~
It just needs the `-lcrack` option to be moved to the end of the command line. Also adds `#include <unistd.h>` to silence the getopt warning.
A patch file from https://github.com/samba-team/samba/pull/114.patch is attached
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: github-pr-candlerb/crackcheck-114.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171214/2eb56fa3/crackcheck-114.patch>
More information about the samba-technical
mailing list