[RFC] [CTDB] Optimized memory handling.
Jeremy Allison
jra at samba.org
Wed Dec 13 23:44:50 UTC 2017
On Thu, Dec 14, 2017 at 10:42:58AM +1100, Amitay Isaacs wrote:
>
> Even without seeing the proof I can imagine the improvements in packet
> handling using the talloc pool. That code is in the hot path and
> avoiding extra malloc() calls will definitely result in reducing the
> load on ctdb daemon. However, as Jeremy mentioned, it would be good
> to verify with real numbers.
>
> As outlined in another email, I would prefer if you make these changes
> in sock_io.c. It will be easier to spin up a self-contained
> performance test using sock_io without needing to run an expensive
> cluster test.
>
> Regarding the actual changes, I wish I had looked at talloc pools
> before. Packet handling is the ideal place for using talloc pools. I
Yep. That's why Volker invented them for smbd :-).
More information about the samba-technical
mailing list