[PATCHES][BUG 13189] Fix coredump on failing chdir during logoff

[Andrew Bartlett]

On Wed, 2017-12-13 at 15:50 -0700, Christof Schmitt wrote:
> On Thu, Dec 14, 2017 at 11:07:00AM +1300, Andrew Bartlett wrote:
> > On Wed, 2017-12-13 at 13:24 -0700, Christof Schmitt via samba-technical 
> > wrote:
> > 
> > This looks great!  I love that you went to such effort to create an
> > automated test for this!
> 
> Thanks. I wanted an easy way to trigger this problem, and it might be
> useful in general to trigger errors for testing. Wrapping that in test
> script was then a quick addition.
> 
> > > +       "SERVERCONFFILE",
> > 
> > This is the only part I don't think you need, you can use SMB_CONF_FILE
> > for this as you are running with :local (that is essentially what
> > :local does). 
> 
> Correct, i missed that part. Updated patches are attached.

I think we should we check that a panic would be detected.  I realise
that is a real pain, but otherwise I fear a change to the logging would
render the patch neutered. 

Just make the fault injection module also call panic directly. 

Then, finally, put the test first, with a knownfail, and then remove
the knownfail with the fix.

To be clear, this is great, but if you can do this one last change I
would appreciate it.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba