[PATCHSET] Add support for fall through attribute

Andrew Bartlett abartlet at samba.org
Tue Dec 12 09:11:17 UTC 2017


On Tue, 2017-12-12 at 08:36 +0100, Andreas Schneider wrote:
> On Thursday, 7 December 2017 11:30:14 CET Andrew Bartlett via samba-technical 
> wrote:
> > On Thu, 2017-12-07 at 11:00 +0100, Andreas Schneider via samba-
> > 
> > technical wrote:
> > > Hello,
> > > 
> > > at least GCC offers a new warning: -Wimplicit-fallthrough
> > > 
> > > It also has an attribute to mark a case in a switch statement as fall
> > > through to disable the warning!
> > > 
> > > 
> > > Please review and push if OK.
> > 
> > This looks great.  I'll look over it more carefully tomorrow, but a big
> > thanks for investigating ways to make our C a little more safe!
> 
> Ping :-)
> 
> 
> Rebased patchset attached!

It looks like tomorrow will be patch review day.  I think I've got the
2012 schema patch set in a shape to be reviewed, so I can do some
review of other things.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list