[Patches] removal of 'auth methods', 'map untrusted to domain' and 'profile acls'

Stefan Metzmacher metze at samba.org
Mon Dec 11 10:28:07 UTC 2017


Hi Andrew,

are you happy with this now?

metze

Am 07.12.2017 um 14:41 schrieb Stefan Metzmacher via samba-technical:
> Hi Andrew,
> 
>> The removal of the auth_winbind_wbclient pdbtest test removes on of the
>> few tests of the NTLM authentication interface in winbindd.  I know it
>> was rather indirect, but it would be good to keep it.
>>
>> On the other hand, it has this TODO:
>>
>> 	/* TODO: 
>> 	 * Compre more details from the two info3 structures,
>> 	 * then test that an expired/disabled/pwdmustchange account
>> 	 * returns the correct errors
>> 	 */
>>
>> If you can show me we have a good test asserting the session key and
>> some other details on this then I can let it go.
>>
>> To be clear, I'm not after the nostalgia, just worried about loss of
>> what little testing we have in some areas.
> 
> Ok, here's an update that inlines the auth_winbind_wbclient code into
> pdbtest.
> 
> As well as the reordering Andreas asked for.
> 
> Please review and push:-)
> 
> Thanks!
> metze
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171211/3bf55d5a/signature.sig>


More information about the samba-technical mailing list