[PATCH] Re: I think sn-devel is stuck... (samba.dsdb test flapping deadlock)

[Andrew Bartlett]

On Thu, 2017-12-07 at 14:25 +0100, Andreas Schneider via samba-
technical wrote:
> On Wednesday, 6 December 2017 02:41:05 CET Andrew Bartlett via samba-technical 
> wrote:
> > On Tue, 2017-12-05 at 17:11 +1300, Andrew Bartlett via samba-technical
> > 
> > wrote:
> > > On Sat, 2017-12-02 at 16:57 +1300, Andrew Bartlett via samba-technical
> > > 
> > > wrote:
> > > > It got stuck on:
> > > > 
> > > > [2024(12875)/2216 at 1h48m41s] samba.tests.dsdb(ad_dc_ntvfs:local)
> > > > 
> > > > Garming found something similar and send me details while I was on
> > > > leave.  Given this has happened more than once I'll look into it next
> > > > week.  Another race condition no doubt...
> > > 
> > > Samba is racing against the test, which is blocking on a pipe.
> > > Production code should never block on anything while holding a lock,
> > > test code that does this on purpose should not operate on a database
> > > that other processes are using, so I'm re-factoring the test.
> > > 
> > > In the meantime, if this happens again just kill the test manually.
> > 
> > Attached is a patch to move this test off the 'live' database.
> > 
> > Please review and push if OK.
> 
> RB+ and pushed. Thanks!

Thanks for pushing that.  Here is a small fix-up to the copyright
header for the new file.

Please review/push with something more significant ;-)

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-selftest-Fix-copyright-header-on-samba.dsdb_lock.patch
Type: text/x-patch
Size: 1061 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171210/ecbb5cb0/0001-selftest-Fix-copyright-header-on-samba.dsdb_lock.bin>