[PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Puran Chand puran157 at gmail.com
Sat Dec 9 01:33:46 UTC 2017


In the mean-time,

PFA the latest patch file from github. :)

On Sat, Dec 9, 2017 at 12:27 AM, Jeremy Allison <jra at samba.org> wrote:

> On Sat, Dec 09, 2017 at 07:48:47AM +1300, Andrew Bartlett wrote:
> > On Fri, 2017-12-08 at 10:32 -0800, Jeremy Allison wrote:
> > > On Thu, Dec 07, 2017 at 03:58:42PM +0530, Puran Chand via
> samba-technical wrote:
> > > > Hi all,
> > > >
> > > > Can I get a second reviewer please on this patch?
> > >
> > > Can you send the patch to the samba-technical mailing list
> > > as a separate message so I can review it please. I generally just
> delete the
> > > github-pull-request messages as I'm not intending to use
> > > a proprietary site to develop Samba.
> >
> > Jeremy,
> >
> > All patches sent via githbub are (again, it was broken for a long
> > while) sent to samba-technical by a bot (that is what you are replying
> > to).
> >
> > I've reviewed the patch (fixing a couple of small style issues) and it
> > is waiting on autobuild.
> >
> > Please don't discourage our contributors.  This method is what we
> > currently document on our wiki as being suitable.
>
> Sorry, I'm not trying to discourage people. I didn't know this was
> documented as
> the 'suitable' way. I don't think it is :-).
>
> > In the meantime I'm working to get a better arrangement working for
> > gitlab.com which I hope will better address your legitimate software
> > freedom concerns.
>
> My issues with the github method at the moment is the flood
> of emails it generates, which makes it almost impossible to
> pick out the actual patch someone wants me to look at.
>
> If it only sent *one* message including the patch I'd probably
> stop moaning about software freedom and be more inclined to
> just look at it (sorry, human nature there :-).
>
> Cheers,
>
>         Jeremy.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: github-pr-set_log_callback_libsmbclient-112.patch
Type: application/octet-stream
Size: 14364 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171209/b37e0f5e/github-pr-set_log_callback_libsmbclient-112.obj>


More information about the samba-technical mailing list