[PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Andrew Bartlett abartlet at samba.org
Fri Dec 8 18:48:47 UTC 2017


On Fri, 2017-12-08 at 10:32 -0800, Jeremy Allison wrote:
> On Thu, Dec 07, 2017 at 03:58:42PM +0530, Puran Chand via samba-technical wrote:
> > Hi all,
> > 
> > Can I get a second reviewer please on this patch?
> 
> Can you send the patch to the samba-technical mailing list
> as a separate message so I can review it please. I generally just delete the
> github-pull-request messages as I'm not intending to use
> a proprietary site to develop Samba.

Jeremy,

All patches sent via githbub are (again, it was broken for a long
while) sent to samba-technical by a bot (that is what you are replying
to).

I've reviewed the patch (fixing a couple of small style issues) and it
is waiting on autobuild.

Please don't discourage our contributors.  This method is what we
currently document on our wiki as being suitable.  

In the meantime I'm working to get a better arrangement working for
gitlab.com which I hope will better address your legitimate software
freedom concerns. 

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list