[PATCHES] samba-tool: implement user show command to display a user AD object

Bjoern Baumbach bb at sernet.de
Fri Dec 8 12:49:50 UTC 2017


Hi Rowland,

thank you for the review.

On 12/08/2017 01:02 PM, Rowland Penny wrote:
> I don't really understand the reason behind this patch, what does it
> give you that an ldbsearch doesn't, where would you use it ?

I would like to introduce a user move command, later, to move a user
into an OU or a different container. With the show command you can
easily display the users DN and further attributes.
I assume that there are users which do not make use of the ldb-tools but
of the samba-tool. The usage is more easy and looks more generic for
them - some of the users are afraid of using the ldb commands directly.

Anyway, if you ask "what does it give you that an ldbsearch doesn't", we
could also remove commands like edit (can be done by ldbedit), list (can
be done by ldbsearch), delete (can be done by ldbdel), ...
But it's nice to have all the commands on one place where a user would
expect and like too see it.

> There are also lines over 80 columns.

I'll fix this.

> I would also think that the typos should be in separate patches.

It is already a separate patch. Or would you split the patch for some
reason?

Best regards,
Björn

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list