[Patches] removal of 'auth methods', 'map untrusted to domain' and 'profile acls'

Andrew Bartlett abartlet at samba.org
Thu Dec 7 10:25:46 UTC 2017


On Thu, 2017-12-07 at 10:36 +0100, Stefan Metzmacher via samba-
technical wrote:
> Hi,
> 
> here're patches to remove the already deprecated options
> 'auth methods', 'map untrusted to domain' and 'profile acls'.
> 
> Please review and push:-)

The removal of the auth_winbind_wbclient pdbtest test removes on of the
few tests of the NTLM authentication interface in winbindd.  I know it
was rather indirect, but it would be good to keep it.

On the other hand, it has this TODO:

	/* TODO: 
	 * Compre more details from the two info3 structures,
	 * then test that an expired/disabled/pwdmustchange account
	 * returns the correct errors
	 */

If you can show me we have a good test asserting the session key and
some other details on this then I can let it go.

To be clear, I'm not after the nostalgia, just worried about loss of
what little testing we have in some areas.

Thanks!

Andrew Bartlett

> Thanks!
> metze
> 
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list