[PATCHES][BUG 13170] Fix crash in pthreadpool thread after failure from pthread_create

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Dec 6 17:19:04 UTC 2017


On Tue, Dec 05, 2017 at 04:23:18PM -0700, Christof Schmitt via samba-technical wrote:
> Another small update. I forgot to clear the inject variable at the end
> of the test. That is not relevant for the test added here, but it causes
> problems when adding more tests after that.

Patches look good. RB+ on the first two ones. Regarding the test: Yes,
it's nasty, but do all linkers support the --wrap option? Do we have
to #ifdef this depending on a configure check? If we can't get a
resolution on this in soon, I'd vote to put in the bugfix without the
test with the promise to actually work on the test. I know, famous
last words, but this is important enough to not be held back by a
cmocka vs linker flag discussion.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list