[PATCH] samba-tool: validate password early in `domain provision`

[Andrew Bartlett]

On Wed, 2017-12-06 at 10:31 +1300, Jamie McClymont via samba-technical
wrote:
> Okay, hopefully the final version...
> 
> Attached version also fixes an ldap test which was using an invalid
> password, allowing the patch to pass all tests.

Thanks Jamie.  In Samba Team practice, the order of fixes and tests
matters.

That is, make test should nominally pass on each commit.  We don't
force the 4-hour test to run on each, but you should make it pass as
far as is reasonable.

So, mark the openldap thing as knownfail when you put the new
restriction in, then fix it removing the knownfail. 

Likewise, in normal cases (where the bug is in the code, not a test),
write the test, set the knownfail, then write the fix removing the
knownfail.

Thanks!

Andrew Bartlett 

> Thanks
> - Jamie
> 
> On 04/12/17 15:46, Jamie McClymont via samba-technical wrote:
> > New patch contains squashed changes plus code-style fixes, as requested irl.
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba