libaesni-intel-samba4.so and execstack flag

[Andreas Schneider]

On Wednesday, 1 November 2017 12:41:45 CET Bjoern Baumbach via samba-technical 
wrote:
> On 10/30/2017 05:00 PM, Jeremy Allison wrote:
> > Hmmm. Can you figure out how to add this to the wscript build
> > so we can add this as a patch ?
> 
> Please find attached a patch which solves the issue on my system. I've
> verified that this does not overwrite other ldflags.
> 
> BUT this breaks the build when using the ADDITIONAL_LDFLAGS option. If I
> specify for example ADDITIONAL_LDFLAGS="-z textoff", gcc is called with
> a 'textoff' argument, without the '-z'. This produces the following error:
> 
> [3457/4105] Linking default/third_party/aesni-intel/libaesni-intel-samba4.so
> gcc: error: textoff: No such file or directory
> 
> 
> I'm not sure if we need to check if the '-z noexecstack' option is
> available on the system or not, and also not how to add this to the waf
> build.
> 
> Do we need a bug report?

Yes, we do!

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org