[PATCH] samba-tool: validate password early in `domain provision`

Andrew Bartlett abartlet at samba.org
Sun Dec 3 22:26:26 UTC 2017


On Mon, 2017-12-04 at 10:57 +1300, Jamie McClymont via samba-technical
wrote:
> Hi all
> 
> Review appreciated.

G'Day Jamie,

This looks good.  Could you look into a test for this, so we can ensure
it keeps working?  Both testing the python binding for
check_password_quality() and please test the integration in samba-tool
even better (there is blackbox testing for samba-tool that can scan for
output strings). 

Thanks,

Andrew Bartlett


-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list