[PATCHS] Fix GPO unapply log

David Mulder dmulder at suse.com
Sat Dec 2 15:48:21 UTC 2017


Fixes for 2 bugs in the gpo unapply.
* The apply log was being left empty. Apparently pointers to tree
elements can't be stored in an object, they somehow are disconnected
from the main tree and nothing gets logged. These have to be found each
time we want to add something. This is probably a bug in python ElementTree.
* We should only commit the earliest change from a gpo to the log.
Otherwise we overwrite the original value written by that gpo, and then
we tattoo the setting on unapply.

 python/samba/gpclass.py | 67
++++++++++++++++++++++++++++++++++++++-----------------------------
 1 file changed, 38 insertions(+), 29 deletions(-)

-- 
David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gpo_fixes.mbox
Type: application/mbox
Size: 8079 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171202/2a6ca69c/gpo_fixes.mbox>


More information about the samba-technical mailing list