[PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

[Puran Chand]

To add more,
I have been using this in my code with samba 4.6.6 release, works well.
Except un-setting part is not tested.

I will test that and will update the patch if required.

On Sat, Dec 2, 2017 at 5:30 PM, Puran Chand <puran157 at gmail.com> wrote:

> Sure Andrew, I will test this and attach the sample code as well by
> Monday..
>
> - Puran
>
> On Sat, Dec 2, 2017 at 10:28 AM, Andrew Bartlett <abartlet at samba.org>
> wrote:
>
>> On Wed, 2017-11-29 at 15:00 +0530, Puran Chand wrote:
>> > This introduces an API in libsmbclient which lets user to set logging
>> callback function which will be called (if set) whenever anything is logged
>> in samba code.
>> > This would be helpful for developers who are linking libsmbclient
>> library and want to direct the logs from samba to different log file.
>> >
>> > Review appreciated.
>>
>> Thanks.  could you just test that it actually works, by printing a
>> message and seeing it in the callback?  Set a flag back via the context
>> pointer and check it after the DEBUG(0, ("foo")) call.  Then please
>> test resetting it with a NULL pointer, not just to test that but also
>> so we have logging in the rest of the test :-).
>>
>> I'm really sorry for how long this has taken.
>>
>> Andrew Bartlett
>> --
>> Andrew Bartlett                       http://samba.org/~abartlet/
>> Authentication Developer, Samba Team  http://samba.org
>> Samba Developer, Catalyst IT          http://catalyst.net.nz/service
>> s/samba
>>
>>
>