[PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs
Andrew Bartlett
abartlet at samba.org
Sat Dec 2 04:58:19 UTC 2017
On Wed, 2017-11-29 at 15:00 +0530, Puran Chand wrote:
> This introduces an API in libsmbclient which lets user to set logging callback function which will be called (if set) whenever anything is logged in samba code.
> This would be helpful for developers who are linking libsmbclient library and want to direct the logs from samba to different log file.
>
> Review appreciated.
Thanks. could you just test that it actually works, by printing a
message and seeing it in the callback? Set a flag back via the context
pointer and check it after the DEBUG(0, ("foo")) call. Then please
test resetting it with a NULL pointer, not just to test that but also
so we have logging in the rest of the test :-).
I'm really sorry for how long this has taken.
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list