[PATCH] testparm, give hint about 'log level'

Andreas Schneider asn at samba.org
Thu Aug 24 12:02:08 UTC 2017


On Thursday, 24 August 2017 13:55:53 CEST Stefan Metzmacher wrote:
> Hi Andreas,
> 
> > If you set 'log level = 10' in the smb.conf file and then run
> > 'testparm -v', the log level will be displayed as '2'. The reason is
> > that testparm sets the default 'log level' to 2. So it will not print
> > what we have in the smb.conf file. We should tell this so users are
> > not confused.
> > 
> > The attached patch adds:
> > 
> > bin/testparm -s -v | grep 'log level'
> > 
> >   log level = 2 # (This is is not the value from smb.conf, but probably
> >   the
> >   
> >                    'default' of this command)
> > 
> > Review appreciated!
> 
> I'd prefer that we find a way to display the correct value instead of a
> warning.
> 
> metze

I've already looked into that, but haven't found an easy way for this. All the 
function just work on the Globals variable ...



	Andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn at cryptomilk.org



More information about the samba-technical mailing list