[PATCHES] Two patches for gpfs sharemodes

Ralph Böhme slow at samba.org
Thu Aug 24 10:31:10 UTC 2017

Hi Christof,

On Wed, Aug 23, 2017 at 01:40:54PM -0700, Christof Schmitt via samba-technical wrote:
> From 9474f1b1865636c7cc53a302b3225e3197f154c1 Mon Sep 17 00:00:00 2001
> From: Christof Schmitt <cs at samba.org>
> Date: Wed, 23 Aug 2017 10:33:42 -0700
> Subject: [PATCH 1/2] vfs_gpfs: Do not map DELETE sharemode access to WRITE
> A SMB client can deny the WRITE sharemode, but still grant the DELETE
> sharemode. Mapping the requested DELETE access to WRITE access breaks
> this case. Fix this by removing the incorrect mapping from DELETE access
> to WRITE access.

I'b be happy to review, alas I fail to understand gpfs_set_share()
API/semantics. Would you or anyone else care to explain how the "allow" and
"deny" parameters are supposed to work? Lacking API documentation for
gpfs_set_share() makes me feel a bit uncomfortable when reviewing this...

From looking at the semantics of the existing code set_gpfs_sharemode(), it
seems as if "allow" is just used to pass the (mapped) access_mask to the
filesystem. Supposedly GPFS then uses the "allow" parameter in a sense of
"requested access" to match against possible deny modes from other opens?

*scratches head*


More information about the samba-technical mailing list