[PATCH] samba.ntstatus and samba.werror Python 3 compatible

Andrew Bartlett abartlet at samba.org
Tue Aug 22 11:07:28 UTC 2017


On Thu, 2017-08-10 at 14:47 +0200, Andreas Schneider via samba-
technical wrote:
> On Tuesday, 8 August 2017 12:00:10 CEST Lumir Balhar via samba-technical 
> wrote:
> > Hello.
> > 
> > I've prepared patches to make samba.ntstatus and samba.werror modules
> > Python 3 compatible. First patch ports generators itself and the second
> > one ports generated Python files.
> > 
> > NTSTATUS_ and WERROR_ constants are widely used among various tests so I
> > think that it's not necessary to write separated testsuite for modules
> > containing only constants. If you think that they should be tested more,
> > I can write some additional testsuite.
> > 
> > Thank you and have a nice day.
> 
> RB+ from my side ...

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Please push!  (otherwise I'll do it in the morning)

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list