Are these used any more? was [PATCH] update autogen-waf.sh

Rowland Penny rpenny at samba.org
Fri Aug 18 20:23:14 UTC 2017


On Sat, 19 Aug 2017 08:08:48 +1200
Andrew Bartlett <abartlet at samba.org> wrote:

> On Fri, 2017-08-18 at 13:22 +0100, Rowland Penny via samba-technical
> wrote:
> > On Fri, 18 Aug 2017 10:37:11 +0200
> > Stefan Metzmacher <metze at samba.org> wrote:
> > 
> > > Hi Rowland,
> > > 
> > > > OK, I have been working through samba-master looking at .sh
> > > > files and I am now wondering whether this is where to start.
> > > > The problem is that I am coming across files I didn't know
> > > > exist and I am now thinking that some of these would be better
> > > > fixed by deleting them.
> > > 
> > > Yes, we have a lot of ancient stuff we don't use/need anymore
> > > and I guess autogen-waf-sh is one of them...
> > > 
> > > metze
> > > 
> > > 
> > 
> > OK, Are any of these used by anybody, or can they be removed ?
> > 
> > samba-master/buildtools/compare_config_h4.sh
> > samba-master/buildtools/compare_generated.sh
> > samba-master/buildtools/wafsamba/test_duplicate_symbol.sh
> > samba-master/buildtools/scripts/autogen-waf.sh
> > samba-master/buildtools/scripts/abi_gen.sh
> > samba-master/buildtools/testwaf.sh
> > samba-master/buildtools/compare_install.sh
> > 
> > samba-master/examples/autofs/auto.smb
> > samba-master/examples/scripts/idmap/idmap_nis.sh
> > samba-master/examples/scripts/mount/mount.smbfs
> > samba-master/examples/scripts/wins_hook/dns_update
> > samba-master/examples/systemtap/generate-winbindd.stp.sh
> > 
> > samba-master/packaging/RHEL/setup/filter-requires-samba.sh
> > samba-master/packaging/RHEL/makerpms.git.sh
> > samba-master/packaging/RHEL-CTDB/makespec.sh
> > samba-master/packaging/RHEL-CTDB/makerpms.sh
> > samba-master/packaging/RHEL-CTDB/setup/filter-requires-samba.sh
> > samba-master/packaging/Solaris/makepkg.sh
> > 
> > samba-master/source3/script/updatesmbpasswd.sh
> > samba-master/source3/script/mksmbpasswd.sh
> > samba-master/source3/script/format_indent.sh
> > samba-master/source3/script/mksyms.sh
> > samba-master/source3/script/mknissmbpasswd.sh
> > samba-master/source3/script/mknissmbpwdtbl.sh
> > 
> > They all seem extremely old, but I am sure some of these are still
> > required, but which ones ?
> 
> To get a short list, first do a 'git grep' over the source tree for
> the base name of each script. 
> 
> $ git grep abi_gen.sh
> buildtools/wafsamba/samba_abi.py:    abi_gen = os.path.join(topsrc,
> 'buildtools/scripts/abi_gen.sh')
> 
> Once you remove the scripts that show up there, then you have a
> smaller list that is easier for another developer to check manually. 
> 
> Thanks!
> 
> Andrew Bartlett

I think I understand what you are saying, if I run the command you
suggest with each base name and get a response showing something else is
using it, remove from the list. Once finished, post the remainder (if
any)

Rowland



More information about the samba-technical mailing list