[PATCH] GUID index for LDB

Andrew Bartlett abartlet at samba.org
Fri Aug 18 19:57:58 UTC 2017

On Thu, 2017-08-17 at 20:22 +1200, Andrew Bartlett via samba-technical
> I'm pleased to day that as I finished work today, I got it working!

I've pushed an updated patch set that fixes an issue in rename. 

This still fails a full make test, but I'll continue to chase down the
regressions over the next week or so. 

That also showed that I'll need to backport a fix our unique index code
in ldb_tdb to make downgrade trivial.  (The fallback of ldbdump /
ldbadd / dbcheck --reindex remains in any case).  I hope to land that
in 4.7 with the py3 ABI changes in the next week. 

> As a guide, with the old code we could, on my workstation with
> TDB_NO_FSYNC set, add this many users to the AD DC in just 2 mins:
> master:  17500
> GUID-index: 25000
> Douglas has kindly queued up a test run on our perf box to see the
> broader impact, and I'll do some larger runs over the weekend.

This showed some things faster, and some things (like indexed search)
much slower, so I'll investigate why that might be, and what we can do
about it.  My hope is that once we sort the GUIDs we can improve the
speed of the index list intersections and recover the lost time, but
first I'll get it under perf and see what changed. 


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list