More patches for smbclient SMB2/3 problems...

[Stefan Metzmacher]

Am 17.08.2017 um 23:18 schrieb Jeremy Allison:
> On Thu, Aug 17, 2017 at 01:05:12AM +0200, Stefan Metzmacher wrote:
>> Hi Jeremy,
>>
>> here's some more patches I have in my tree.
>> I haven't done much testing with them yet.
>>
>> I'll start a private autobuild now.
>>
>> metze
> 
>> From c7b7bd9fa12f614469c6447047b3f8e6f534fdee Mon Sep 17 00:00:00 2001
>> From: Stefan Metzmacher <metze at samba.org>
>> Date: Sat, 8 Jul 2017 00:57:59 +0200
>> Subject: [PATCH 1/5] s3:libsmb: let get_ipc_connect() use
>>  CLI_FULL_CONNECTION_FORCE_SMB1
>>
>> get_ipc_connect() is only used for calling cli_NetServerEnum().
>>
>> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12876
> 
> FYI. This isn't actually true - there is a path
> inside source3/utils/smbtree.c inside get_shares()
> where get_ipc_connect() is used before calling
> get_rpc_shares(), which uses dcerpc_srvsvc_NetShareEnumAll(),
> not cli_NetServerEnum() to enumerate shares.
>
> Having said that get_shares() is only called
> after get_workgroups() returns true, and
> get_workgroups() uses old-style NetBIOS broadcast
> and cli_NetServerEnum() to get the server list,
> so it can't work without SMB1.

Yes, that's what I also found.

> Might change the commit comment to record this though...

Ok, can you just add your above comments to the commit message?

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170817/6bc96e39/signature.sig>