[PATCH] Fix bug 12968 - smbclient tarmode doesn't work with SMB2/3.

Jeremy Allison jra at samba.org
Thu Aug 17 15:47:25 UTC 2017


On Thu, Aug 17, 2017 at 08:08:53AM +0200, Volker Lendecke wrote:
> On Wed, Aug 16, 2017 at 03:54:12PM -0700, Jeremy Allison via samba-technical wrote:
> > +	if (namelen > 0 && name[namelen-1] == '\\') {
> > +		char *modname = talloc_strdup(talloc_tos(), name);
> > +		modname[namelen-1] = '\0';
> 
> NULL check required here I guess.

Good catch. As the underlying call also does this
I'll just remove this I think.



More information about the samba-technical mailing list