[PATCH] util: Add documentation for PID file handling

Martin Schwenke martin at meltin.net
Thu Aug 17 08:42:35 UTC 2017


On Thu, 17 Aug 2017 17:33:43 +1000, Amitay Isaacs <amitay at gmail.com>
wrote:

> On Thu, Aug 17, 2017 at 4:17 PM, Martin Schwenke via samba-technical <
> samba-technical at lists.samba.org> wrote:
> 
> > Please review and maybe push...
> >  
> 
> Two minor fixes:
> 
> 1. Update description of pidfile_path_create
> 
>  - * another process has the PID file locked.  Use unlink(2) to remove
> - * the PID file.
> + * another process has the PID file locked.  Use unlink(2) and
> + * pidfile_fd_close() to remove the PID file.
> 
> 2. Make the prototype match the documentation for pidfile_create() and
> pidfile_close().
> 
> Change program_name to name.

Thanks.  :-)

I noticed (2) while writing the documentation but obviously forgot to
fix it.  :-(

New patch attached...

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-util-Add-documentation-for-PID-file-handling.patch
Type: text/x-patch
Size: 2680 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170817/a99964c6/0001-util-Add-documentation-for-PID-file-handling.bin>


More information about the samba-technical mailing list