[PATCH] Utilities: clean up become_daemon
asn at samba.org
Thu Aug 17 05:46:14 UTC 2017
On Thursday, 17 August 2017 06:14:57 CEST Martin Schwenke wrote:
> Hi Andreas,
> On Wed, 16 Aug 2017 16:54:10 +0200, Andreas Schneider <asn at samba.org>
> > On Wednesday, 16 August 2017 12:51:41 CEST Martin Schwenke via
> > samba-technical>
> > wrote:
> > > We would like to use become_daemon in CTDB. Here are some clean ups.
> > > The only real functional change is the addition of some error checking
> > > in become_daemon() itself, so that we notice fails fork() and setsid().
> > Shouldn't
> > +
> > #include "lib/util/close_low_fd.h"
> > +#include "lib/util/debug.h"
> > +
> > +#include "lib/util/samba_util.h"
> > be
> > #include "close_low_fd.h"
> > #include "debug.h"
> > #include "samba_util.h"
> > They are all in the same directory as the C file itself ...
> Sure. Right now there are about 100 #includes in lib/util/ with
> "lib/util/..." and about 150 local #includes without any directory. I
> guess it make sense to keep the local includes relative to the current
> Updated patch attached...
Pushed to master, thanks!
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical