[PATCH] Fix bug 12968 - smbclient tarmode doesn't work with SMB2/3.

[Stefan Metzmacher]

Am 17.08.2017 um 01:15 schrieb Jeremy Allison:
> On Thu, Aug 17, 2017 at 01:02:36AM +0200, Stefan Metzmacher wrote:
>> Am 17.08.2017 um 00:56 schrieb Stefan Metzmacher via samba-technical:
>>> Hi Jeremy,
>>>
>>>> As Metze points out in the bug report, cli_chkpath()
>>>> is missing an SMB2 implementation.
>>>>
>>>> Please review and push if happy !
>>>
>>> I had the following version for this...
>>>
>>> I don't care which one we take, please push one of it.
> 
> I prefer my version as it handles the "path ending
> in /" case, which is commonly used from higher-level
> code.

Mine also handles that, in cli_chkpath() and
cli_smb2_create_fnum_send() also already handles that.

But I don't care much.

>> I also had this addition...
>>
>> Please review and push together with one fix for cli_chkpath().
> 
> RB+ and pushed.
> 
> I'll cherry-pick back for the bug report once it goes
> in.
> 
> Can you review the updated cherry-pick patch for 4.7.x
> on bug: https://bugzilla.samba.org/show_bug.cgi?id=12932 ?
> 
> It'd be good to get that in the release.

Yes.

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170817/8cc34df4/signature.sig>