[PATCH] Fix bug 12968 - smbclient tarmode doesn't work with SMB2/3.

[Stefan Metzmacher]

Am 17.08.2017 um 00:56 schrieb Stefan Metzmacher via samba-technical:
> Hi Jeremy,
> 
>> As Metze points out in the bug report, cli_chkpath()
>> is missing an SMB2 implementation.
>>
>> Please review and push if happy !
> 
> I had the following version for this...
> 
> I don't care which one we take, please push one of it.

I also had this addition...

Please review and push together with one fix for cli_chkpath().

Thanks!
metze

-------------- next part --------------
From 1c8037c1ed9d5731cf63fd868467ca84842bd6b5 Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <metze at samba.org>
Date: Wed, 16 Aug 2017 22:27:15 +0200
Subject: [PATCH] libcli/smb: debug an error if smb1cli_req_writev_submit() is
 called for SMB2/3

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12968

Signed-off-by: Stefan Metzmacher <metze at samba.org>
---
 libcli/smb/smbXcli_base.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index cc89789..d73949b 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -1661,6 +1661,9 @@ static NTSTATUS smb1cli_req_writev_submit(struct tevent_req *req,
 	}
 
 	if (state->conn->protocol > PROTOCOL_NT1) {
+		DBG_ERR("called for dialect[%s] server[%s]\n",
+			smb_protocol_types_string(state->conn->protocol),
+			smbXcli_conn_remote_name(state->conn));
 		return NT_STATUS_REVISION_MISMATCH;
 	}
 
-- 
1.9.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170817/1910837b/signature.sig>